Fixed OpentraceableClientE2ETest to be more deterministic #5536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…explanation of what it should test) Disabled BulkheadTest that is failing intermittently
oracle-contributor-agreement
bot
added
the
OCA Verified
tomas-langer
commented
Nov 25, 2022
| @@ -42,14 +44,19 @@ class BulkheadTest { | |||
|
|
|||
| private static final long WAIT_TIMEOUT_MILLIS = 10000; | |||
|
|
|||
| private final CountDownLatch enqueuedSubmitted = new CountDownLatch(1); | |||
| private CountDownLatch enqueuedSubmitted; | |||
There was a problem hiding this comment.
This change is done to allow @RepeatedTest to be used on testBulkhead to reproduce intermittent failure
danielkec
approved these changes
Nov 28, 2022
trentjeff
pushed a commit
to trentjeff/helidon
that referenced
this pull request
Nov 29, 2022
…#5536) * Fixed OpentraceableClientE2ETest to be more deterministic (and added explanation of what it should test) Disabled BulkheadTest that is failing intermittently * Fixed tests that leave current span scope open (and influence other tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and added explanation of what it should test)
Disabled BulkheadTest that is failing intermittently
Resolves #5487